Conversation
ReinierMaas
approved these changes
Sep 22, 2026
ReinierMaas
left a comment
ReinierMaas
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for the additional documentation. I only require one small revert.
| error = as_dyn_error(&e), | ||
| "Opsqueue consumer client background task closing: {e}" | ||
| ); | ||
| break; |
Member
There was a problem hiding this comment.
Could you revert this change? We intentionally do not include the error in the message here.
What happens is that the error is reported to Sentry and the error chain is connected via the as_dyn_error which renders every error in the chain separately. By including it in the message the underlying errors are reported twice (and thrice for three levels deep etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote some comments as I was trying to understand this code. Hopefully it helps a future reader.